[CI] Modernize and harden Agent Stack Kubernetes installer - #441
Draft
mgoin wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source review found that the Kubernetes installer was stale. Against the tested Buildkite Agent Stack chart, it passes invalid
config.org, does not select a queue (and therefore targets the default queue), floats the chart version, and still requires obsolete GraphQL configuration.This change:
agent-stack-k8schart default to0.46.3;BUILDKITE_AGENT_QUEUE(b200-k8sfor the B200 queue);config.organd obsolete GraphQL settings;Validation
bash -n infra-k8s/install-buildkite-k8s.shkoalaman/shellcheck:stablegit diff --checkalpine/helm:3.19.0, chart0.46.3, a dummy token, andBUILDKITE_AGENT_QUEUE=b200-k8s; verified the queue, metrics annotations, controller image, and resource requests0.46.3controller image; configuration loading succeeded and stopped only at the expected missing in-cluster Kubernetes environmenthelm get valuesandhelm get manifest, then compare them with this render so existing deployment-specific settings are preserved.>=1.29.0-0requirement and confirm the cluster agent token is correct.b200-k8sfor B200.Non-goals
No live cluster was accessed. This does not provide or claim control-plane HA. It does not add storage limits without measurements.
No overlapping open PR was found for the installer/Agent Stack/B200 reliability searches.